Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize style and environment in DOMRenderer #215

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Generalize style and environment in DOMRenderer #215

merged 2 commits into from
Jul 27, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

Moves DOMNode to a separate file and reduces style and environment duplication in overloaded DOMRenderer initializers.

@MaxDesiatov MaxDesiatov requested review from carson-katri and j-f1 July 26, 2020 19:34
@MaxDesiatov MaxDesiatov added the refactor No user-visible functionality change label Jul 26, 2020
carson-katri
carson-katri previously approved these changes Jul 26, 2020
View reviewed changes
@MaxDesiatov MaxDesiatov requested a review from carson-katri July 26, 2020 20:16
@MaxDesiatov MaxDesiatov merged commit 6624844 into main Jul 27, 2020
@MaxDesiatov MaxDesiatov deleted the refactor-domrenderer branch July 27, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-f1 j-f1 j-f1 approved these changes

@carson-katri carson-katri Awaiting requested review from carson-katri

Assignees
No one assigned
Labels
refactor No user-visible functionality change
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxDesiatov @carson-katri @j-f1